Repository navigation
Give request-ID refusals their own exit codes and qualify Server 3.13.0 - #167
Merged
Merged
Conversation
A signal or update refused with HTTP 409 request_id_conflict now exits 9 (REQUEST_ID_CONFLICT) and request_id_ambiguous exits 10 (REQUEST_ID_AMBIGUOUS), with a request_id.ambiguous next step. Both are definite refusals that recorded nothing; other 409s keep exit 2. A legacy receipt (retained, intent not verified) is no longer shown as a plain "Intent Verified: no" match: the human output says the Server did not compare the command's intent. The PHP source reference mirrors the change so php-main parity holds, with new ambiguity parity cases. scripts/acceptance/command-keys/published_cohort.py is a self-contained installed cohort against a published native Server by digest: response loss with generated and explicit keys, concurrency, changed-intent conflicts, Unicode limits, closed/continued/fenced runs, namespaces, and synthetic legacy readback and ambiguity through the Rust SDK held-FD helper. published-command-keys.yml runs it for the released CLI and this checkout (durable-workflow/.github#216). Co-Authored-By: Claude Opus 5.5 <[email protected]>
Extract the ambiguity next step and the legacy receipt line out of nested branches in the PHP reference, give the cohort's repeated literals names, bind loop variables in its concurrent lambdas, replace the generated-key regex with a plain hex check, and fix the legacy readback concurrency to the accepted vector's four. Classify scripts/acceptance like scripts/conformance as test code for analysis: these are operator-run harnesses whose inputs are hash-checked before use. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



CLI side of durable-workflow/.github#216 (safe signal/update retries after a lost response), against the published native Server 3.13.0 (
ghcr.io/durable-workflow/server@sha256:30ccaf2c…, source2d1244be).CLI change
REQUEST_ID_CONFLICTfor HTTP 409request_id_conflict(the key names a retained command with a different name, input or run target). Previously exit 2.REQUEST_ID_AMBIGUOUSfor HTTP 409request_id_ambiguous, with a newrequest_id.ambiguousnext step: nothing was recorded, no receipt was selected, and retrying unchanged fails the same way.request_id,reasonand the Server'sserver_response. Other 409s (for examplerun_not_active) keep exit 2.retained: true,intent_verified: false) now printsIntent Verified: no (legacy receipt; the Server did not compare this command's intent with it). JSON passes both fields through unchanged.--request-idonecli-<signal|update>-<32 hex>key is generated per invocation; signal/update make exactly one request and never resend (the key is in the error envelope for a manual retry).batch:*already treats any 409request_id*refusal as refused, not retryable, and resends only with the manifest's stored key.src/) mirrors the exit codes, message and receipt line so thephp-mainparity cases stay equal. New parity cases cover ambiguity (signal JSON and human, update JSON).docs/cli-reference.mddocuments exit codes 9 and 10 and the current Server contract.Installed cohort
scripts/acceptance/command-keys/published_cohort.pyis a self-contained runner. It uses the shared response-loss proxy (.github117118c8,bd1e8ccb…) and the Rust SDK's held-descriptorsqlite_legacy.pyand legacy vectors (sdk-rust6280877b,4446843f…/da199000…). Each input is checked against its SHA256 before use. The Server runs capped (1 CPU, 1 GiB, 256 PIDs, read-only root, loopback port), and every container it creates is removed and checked absent afterwards.retained: true, intent_verified: falsewith four concurrent readers. Human output never shows the receipt as verified.two-rows,legacy-token,modern-raw) returnrequest_id_ambiguouswith no receipt selected.lab4, linux/amd64, 2026-11-19 UTC, final runner
8f8b4325…(head524c37f):dfd1d041…, refusals exit 2)--typed-exit-codes: 9 / 10)The same four cells passed on hosted runners in Published command keys 44470692107 at
524c37f(and 44469896270 at5043225).Cleanup passed for every run. No Server defect was found.
.github/workflows/published-command-keys.ymlruns the same four cells on hosted runners: the published binary from the release (SHA256-pinned), and this checkout built with Rust 1.99. It triggers on changes to the cohort, the workflow,rust/src/error.rsandrust/src/commands/workflow_message.rs, or on manual dispatch.Analysis
sonar-project.propertiesnow classifiesscripts/acceptance/**as test code, likescripts/conformance/**. These are operator-run harnesses whose inputs are SHA256-checked before use. The code smells Sonar raised were fixed rather than excluded.Not covered
🤖 Generated with Claude Code